Travis: Re-enable Android builds #37729
Merged
+11
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
commented
Apr 9, 2020
| # - openjdk-8-jdk | ||
| - name: Android export template (release_debug, Clang) | ||
| stage: build | ||
| env: PLATFORM=android TOOLS=no TARGET=release_debug CACHE_NAME=${PLATFORM}-clang EXTRA_ARGS="werror=yes" |
There was a problem hiding this comment.
I had to remove warnings=extra as currently it raised warnings in the thirdparty vk_mem_alloc.h from the NDK.
It should be fixed to build in a separate env with disable_warnings() as done in drivers/vulkan/SCsub (cc @pouleyKetchoupp).
There was a problem hiding this comment.
On Android, we don't build Vulkan source like we do on other platforms, and the error occurs when vk_mem_alloc.h is included in our source.
I'm going to fix it by using GCC diagnostic ignored when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android support is back thanks to #36919 🎉