Expose AnimationNodeOneShot::mix_mode as a property #37945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
approved these changes
Sep 2, 2021
theraot
reviewed
Oct 2, 2021
| @@ -339,6 +339,8 @@ void AnimationNodeOneShot::_bind_methods() { | |||
| ClassDB::bind_method(D_METHOD("set_use_sync", "enable"), &AnimationNodeOneShot::set_use_sync); | |||
| ClassDB::bind_method(D_METHOD("is_using_sync"), &AnimationNodeOneShot::is_using_sync); | |||
|
|
|||
| ADD_PROPERTY(PropertyInfo(Variant::INT, "mix mode", PROPERTY_HINT_ENUM, "Blend, Add"), "set_mix_mode", "get_mix_mode"); | |||
There was a problem hiding this comment.
I suggest using "mix_mode" instead of "mix mode" (which is the pattern for properties everywhere).
To be clear, the change as it is fixes the bug (makes the property available on the Inspector Panel when the node is selected). I'm thinking about not adding extra hassle for scripting.
There was a problem hiding this comment.
Indeed, the fixed part is right, but the formatting is not right. I did not test it properly, so overlooked it.
There was a problem hiding this comment.
Thanks for the review, I force pushed an update to fix this.
akien-mga
approved these changes
Jan 25, 2022
akien-mga
added
cherrypick:3.4
cherrypick:3.x
akien-mga
changed the title
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.4.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23458