-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packet tracking stats for 3.2 #38306
Conversation
I don't like the idea of making this ENetPeer-specific. Since we need to track this manually, it would be best to have it in MultiplayerAPI. |
Could be moved upper towards the NetworkPeer? I feel like it's very implementation specific (i.e. there are some client/server configuration messages that aren't taken into account on upper layers) and having it on the lowest level allows for real deep optimizations, but that's just my point of view on my specific need. The code isn't really that complex so moving it to somewhere where it makes more sense/is more broad couldn't harm. |
Well, it could be peer dependent, but not in the way it's currently implemented. As an example, bytes_sent does not reflect the actual number of payload sent in the network when e.g. compression is enabled, or when the server broadcast a message to all peers, |
Gotcha, indeed, i wanted to be able to check how much data is being sent and received on the client side mainly to optimize that side, but indeed this could be an issue if the server isn't calculating correctly the amounts. Will do a fix when i finish my other current module. |
@chiguireitor Hi, do you still work on this? It would be useful addition. |
@yuraj11 i'm using this on a personal fork of mine for development purposes.... doing an mmorpg needs closely monitoring of the usage on mobile..... it works ok for me, lemme know if you use it |
@Calinou Well it would be also useful to be available as API for in game debug purposes. |
This PR adds additional functionality to the ENet module to enabled packet statistics tracking (packets sent/received, bytes sent/received) useful for debugging multiplayer games.