Proper surface reset when resuming app on Android #39004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @m4gr3d for review |
Calinou
added
bug
topic:rendering
platform:android
topic:porting
and removed
topic:rendering
labels
m4gr3d
reviewed
May 24, 2020
| // Update the native renderer instead of restarting the app. | ||
| // GodotLib.newcontext should not be called here once it's done. | ||
| GodotLib.newcontext(surface, false) | ||
| GodotLib.resetsurface(surface) |
There was a problem hiding this comment.
Seems the call order here is important since DisplayServerAndroid uses the size set by GodotLib.resize here to reset the window.
Would it be simpler to merge the two methods? Or to expand resetsurface to also take a width and height arguments and drop the call to resize for the VkRenderer?
There was a problem hiding this comment.
Ok, no problem to merge them.
Just re-creating the window instead of restarting the app entirely.
pouleyKetchoupp
force-pushed
the
android-reset-surface
branch
from
2de5580 to
b987677
Compare
|
Changes from review done! |
m4gr3d
approved these changes
May 24, 2020
|
Thanks! |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just re-creating the window instead of restarting the app entirely after pausing and resuming.
Addresses remaining issue listed in #36919:
Properly handle
onVkSurfaceChangedevent to update the rendering system