Stop ignoring hidden files and directories in the assets directory
#39049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
added
platform:android
topic:buildsystem
cherrypick:3.x
akien-mga
reviewed
May 25, 2020
|
Thanks! |
|
Cherry-picked for 3.2.2. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commented in the change:
The default ignore pattern for the 'assets' directory includes hidden files and directories which are used by Godot projectsIt hasn't affected
apks generated by the editor because the editor directly inserts the needed files and directories (including hidden ones) in theassetsdirectory after theapkhas been generated.But it's safer to remain consistent.