Windows error logs directed to stderr

[ThakeeNathees]

it makes more harder to run tests with those error logs

[Calinou]

For consistency, this should also be done on macOS and Linux if not done already.

[akien-mga]

I'm not sure to understand the rationale, what difference does it make on Windows? Doesn't it print stdout and stderr to the same cmd.exe anyway?

[ThakeeNathees]

Doesn't it print stdout and stderr to the same cmd.exe anyway

yeah, it'll print everything on the console unless redirecting stdout or stderr to another stream like
> godot 2> stderr.txt this wont print errors but dump them to stderr.txt
> godot > stdout.txt 2> stderr.txt this wont print any thing but dump to separate files

[Calinou]

I think this is a good feature, but we need to harmonize this behavior with Linux and macOS (if not done already).

[akien-mga]

This makes it consistent with Unix systems:

godot/drivers/unix/os_unix.cpp

Lines 562 to 579 in df62d9f

	switch (p_type) {
	case ERR_WARNING:
	logf_error("%sWARNING:%s %s\n", yellow_bold, yellow, err_details);
	logf_error("%s at: %s (%s:%i)%s\n", gray, p_function, p_file, p_line, reset);
	break;
	case ERR_SCRIPT:
	logf_error("%sSCRIPT ERROR:%s %s\n", magenta_bold, magenta, err_details);
	logf_error("%s at: %s (%s:%i)%s\n", gray, p_function, p_file, p_line, reset);
	break;
	case ERR_SHADER:
	logf_error("%sSHADER ERROR:%s %s\n", cyan_bold, cyan, err_details);
	logf_error("%s at: %s (%s:%i)%s\n", gray, p_function, p_file, p_line, reset);
	break;
	case ERR_ERROR:
	default:
	logf_error("%sERROR:%s %s\n", red_bold, red, err_details);
	logf_error("%s at: %s (%s:%i)%s\n", gray, p_function, p_file, p_line, reset);
	break;

[akien-mga]

Thanks!

[akien-mga]

Cherry-picked for 3.4.