Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript Documentation-System UI implementations #39849

Closed

Conversation

ThakeeNathees
Copy link
Contributor

@ThakeeNathees ThakeeNathees commented Jun 26, 2020

This PR is the UI implementation part of #39359 #41095 (my GSoC project) I split the pr into core and UI.
Note: this pr depend on #41095 (yet it needs some changes to work with #41095 after merged. I've marked TODOs for dependencies )

Images

Capture

doc-ui

@ThakeeNathees ThakeeNathees marked this pull request as draft June 26, 2020 14:52
@aaronfranke aaronfranke added this to the 4.0 milestone Jun 27, 2020
@ThakeeNathees ThakeeNathees force-pushed the GDScript-DocUI branch 3 times, most recently from ccc3762 to 3f0c10c Compare July 4, 2020 10:42
@ThakeeNathees ThakeeNathees marked this pull request as ready for review July 24, 2020 13:42
@ThakeeNathees ThakeeNathees force-pushed the GDScript-DocUI branch 6 times, most recently from ccfc130 to c7d822a Compare August 12, 2020 17:16
@ThakeeNathees ThakeeNathees changed the title [WIP] GDScript Documentation-System UI implementations GDScript Documentation-System UI implementations Aug 12, 2020
- multiline doc-comment auto completion implementation
- auto brace completion, indentation, etc. implementation
@ThakeeNathees ThakeeNathees force-pushed the GDScript-DocUI branch 2 times, most recently from 34070ea to 42d3bb1 Compare August 30, 2020 12:56
- An option to generate script documentation added to file menue.
- JSON format added.
@SIsilicon
Copy link

SIsilicon commented Feb 7, 2021

I wonder what's the status on this? I'm currently making an add-on in 3.2 that displays GDScript documentation along with the other built-in classes. I never knew this PR existed until someone pointed it out to me.

@ThakeeNathees
Copy link
Contributor Author

@SIsilicon there are some improvements and implementation to do (I haven't tested this after the documentation system merged). and need some review from the core devs. If you have any suggestions let me know. However, it's not compatible with Godot 3.x. And it possibly will be included in 4.0 or later. Meanwhile, I'll try to polish this.

@Xwdit
Copy link
Contributor

Xwdit commented Dec 18, 2021

Hi, is there any progress recently? Can’t wait for this pr to be merged 😆

@YuriSizov YuriSizov modified the milestones: 4.0, 4.x Aug 17, 2022
@YuriSizov
Copy link
Contributor

This needs some work to bring up to date, but it's also not a compat breaking change which can be resolved in any future 4.x version. So I'm kicking it to the 4.x milestone.

Another reason is that the API part of this PR has an up to date version in #62928, while the user interface may be an overkill and better left for users to implement to their spec.

@YuriSizov
Copy link
Contributor

The feature itself is now implemented in #76490. If there is a demand for a GUI version, then I guess a new PR is needed at this point. Thanks for your work nonetheless!

@YuriSizov YuriSizov closed this May 15, 2023
@YuriSizov YuriSizov removed this from the 4.x milestone Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants