Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added const qualifier support for function arguments in shaders #40010

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Added const qualifier support for function arguments in shaders #40010

merged 1 commit into from
Jul 1, 2020

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jul 1, 2020

Allow 'const' qualifier in shader function declaration like:

void test(const int t){
}

@Chaosus Chaosus requested a review from reduz as a code owner July 1, 2020 09:24
@Chaosus Chaosus modified the milestones: 3.2, 4.0 Jul 1, 2020
@Chaosus Chaosus requested a review from clayjohn July 1, 2020 09:27
@Chaosus Chaosus force-pushed the shader_func_arg_const_qual branch 2 times, most recently from 5ba7c86 to 472e52c Compare July 1, 2020 09:52
@Chaosus Chaosus force-pushed the shader_func_arg_const_qual branch from 472e52c to c554d9e Compare July 1, 2020 09:55
@akien-mga akien-mga merged commit 77e4794 into godotengine:master Jul 1, 2020
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the shader_func_arg_const_qual branch July 1, 2020 14:41
@Chaosus Chaosus mentioned this pull request Jul 3, 2020
Merged
@Calinou Calinou mentioned this pull request Nov 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reduz reduz Awaiting requested review from reduz

@clayjohn clayjohn Awaiting requested review from clayjohn

Assignees
No one assigned
Labels
enhancement topic:shaders
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Chaosus @akien-mga