Android: Keyboard modifier and arrow key support for text edit

[thebestnom]

Needed for #36776, also I think it's a welconiing change anyway

thinking changing InputEventScreenTouch and InputEventScreenDrag to inherit from InputEventWithModifiers instead so they could also get benefits from this PR

(if someone have better option for what I did on onKeyDown in GodotEditText I would be glad to hear)

Tested on Android Editor and https://github.com/thebestnom/Android-Tester

[pouleyKetchoupp]

I've just checked the code and haven't tested yet. The DisplayServer part looks fine (apart from the comment by @akien-mga), and for now I don't clearly understand the java side.

I assume this change is only meant to be used for an actual connected keyboard? It's hard to tell how this might affect the case with virtual keyboard so it needs proper testing.

[thebestnom]

Also I just saw that EditText didn't handle keyUp event, so I'm adding that

[thebestnom]

also tested with virtual keyboard and it doesn't seem to interfere

[thebestnom]

thinking changing InputEventScreenTouch and InputEventScreenDrag to inherit from InputEventWithModifiers instead so they could also get benefits from this PR

asking again, any comment on this?

[pouleyKetchoupp]

thinking changing InputEventScreenTouch and InputEventScreenDrag to inherit from InputEventWithModifiers instead so they could also get benefits from this PR

It would be probably ok to change if needed, but is there an actual use case for an editor or game feature that could benefit from it? Pressing keyboard keys along with touch events doesn't seem user-friendly.

[thebestnom]

It would be probably ok to change if needed, but is there an actual use case for an editor or game feature that could benefit from it? Pressing keyboard keys along with touch events doesn't seem user-friendly.

I'm comming from the point of view of Android Editor where there it's pretty handy, but for other pojects most I can think of is testing your game on device/playing on chromeOS/playing on tablet without special touch control and in those cases a lot of time you can use drag or touch with one hand

[pouleyKetchoupp]

I'm comming from the point of view of Android Editor where there it's pretty handy, but for other pojects most I can think of is testing your game on device/playing on chromeOS/playing on tablet without special touch control and in those cases a lot of time you can use drag or touch with one hand

I understand it's physically possible in some cases but I would be for adding support for it only when there's a specific use case scenario that requires it.

[m4gr3d]

Most of the logic looks good; just a couple of comments to address.

[akien-mga]

Needs a rebase to fix CI builds (at least Linux - not sure why macOS fail but a new build will likely let it pass).

[thebestnom]

@akien-mga rebased :)

[akien-mga]

Thanks!