Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose bookmark, breakpoint, and mark safe functions in TextEdit #40629

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Expose bookmark, breakpoint, and mark safe functions in TextEdit #40629

merged 1 commit into from
Jan 27, 2021

Conversation

HaSa1002
Copy link
Contributor

I am working on tool and need those functions exposed. I think they should be exposed, because they are public methods and you can even set the theme properties for them. There is a lot more to expose still...

@HaSa1002 HaSa1002 requested a review from a team as a code owner July 23, 2020 13:08
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:gui labels Jul 23, 2020
@Calinou Calinou added this to the 4.0 milestone Jul 23, 2020
@Paulb23 Paulb23 mentioned this pull request Aug 2, 2020
Merged
@HaSa1002
Copy link
Contributor Author

Can this be 3.2 only? I need it for my code translation tool

akien-mga
akien-mga reviewed Jan 27, 2021
View reviewed changes
doc/classes/TextEdit.xml Outdated
<argument index="0" name="line" type="int">
</argument>
<description>
Returns [code]true[/code] when the specified [code]line[/code] is bookmarked.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be indented one level more. Running doctool should fix it for you.

@HaSa1002 HaSa1002 changed the base branch from master to 3.2 January 27, 2021 11:07
@akien-mga
Copy link
Member

Can this be 3.2 only? I need it for my code translation tool

I'm not fond of exposing those APIs which are made specifically for Godot's code editor and not for a general purpose text editor. They're so specific that it opens the way for users requesting adding other similar and highly use-case specific APIs...

That being said this concern has been addressed in 4.0 by moving this stuff to CodeEdit which is much more appropriate, so I guess we can expose these for 3.2 in the meantime.

@HaSa1002 HaSa1002 force-pushed the expose-textedit-safe branch 2 times, most recently from 5ed24c6 to e656af5 Compare January 27, 2021 21:28
akien-mga
akien-mga reviewed Jan 27, 2021
View reviewed changes
doc/classes/TextEdit.xml Outdated
@@ -261,6 +261,33 @@
<description>
Returns whether the line at the specified index is hidden or not.
</description>
</method>
<method name="is_line_set_as_bookmark" qualifiers="const">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation issue here.

akien-mga
akien-mga reviewed Jan 27, 2021
View reviewed changes
doc/classes/TextEdit.xml Outdated
@@ -356,6 +383,29 @@
<description>
Sets the text for a specific line.
</description>
</method>
<method name="set_line_as_bookmark">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here.

akien-mga
akien-mga reviewed Jan 27, 2021
View reviewed changes
doc/classes/TextEdit.xml Outdated Show resolved Hide resolved
akien-mga
akien-mga reviewed Jan 27, 2021
View reviewed changes
doc/classes/TextEdit.xml Outdated Show resolved Hide resolved
akien-mga
akien-mga reviewed Jan 27, 2021
View reviewed changes
doc/classes/TextEdit.xml Outdated Show resolved Hide resolved
@HaSa1002 HaSa1002 force-pushed the expose-textedit-safe branch from b895701 to 5cf3024 Compare January 27, 2021 21:37
@HaSa1002
Copy link
Contributor Author

Sorry for the mess I created while changing the base. Should be same commit now. And fixed all the issues. Had to apply the patch by hand...

akien-mga
akien-mga reviewed Jan 27, 2021
View reviewed changes
doc/classes/TextEdit.xml Outdated Show resolved Hide resolved
@HaSa1002 HaSa1002 force-pushed the expose-textedit-safe branch from d881348 to 4ff0df7 Compare January 27, 2021 21:41
@akien-mga akien-mga merged commit dae72fc into godotengine:3.2 Jan 27, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@AndreaCatania AndreaCatania Awaiting requested review from AndreaCatania

@hpvb hpvb Awaiting requested review from hpvb

@neikeq neikeq Awaiting requested review from neikeq

@reduz reduz Awaiting requested review from reduz

@vnen vnen Awaiting requested review from vnen

Assignees
No one assigned
Labels
enhancement topic:gui
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@HaSa1002 @akien-mga @Calinou