Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chorus effect inspector update voices automatically #41575

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

kotelifelif
Copy link
Contributor

@kotelifelif kotelifelif commented Aug 28, 2020

I update property "voice_count" in audio_effect_chorus.cpp to close #20003 issue.

@kotelifelif
Copy link
Contributor Author

kotelifelif commented Aug 28, 2020

#31627
#20003

@Zireael07
Copy link
Contributor

PR title on the website and the commit message should stand on their own, without people having to check what 31627 is about.

@kotelifelif kotelifelif changed the title Solve 31627 issue Chorus effect inspector update voices automatically Aug 28, 2020
@Calinou Calinou added bug cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:editor labels Aug 28, 2020
@Calinou Calinou added this to the 4.0 milestone Aug 28, 2020
@akien-mga akien-mga requested a review from a team February 25, 2021 16:30
@akien-mga
Copy link
Member

Force pushed an amend to make the commit message more explicit.

@akien-mga akien-mga merged commit 9e24ad5 into godotengine:master Feb 25, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants