Deprecate Redundant property enabled_focus_mode #41577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIF15
force-pushed
the
deprecate-redundant-property-enabled-focus-mode
branch
from
3aca392
to
e228a4c
Compare
akien-mga
reviewed
Oct 2, 2020
akien-mga
reviewed
Oct 2, 2020
akien-mga
reviewed
Oct 2, 2020
|
@akien-mga, your suggestions are applied. Thanks. |
akien-mga
reviewed
Oct 14, 2020
|
Could you squash the commits into one? |
sure |
FIF15
force-pushed
the
deprecate-redundant-property-enabled-focus-mode
branch
from
6903853
to
79a93d8
Compare
akien-mga
reviewed
Oct 15, 2020
of BaseButton see godotengine#41529 for details this closes godotengine#41529
FIF15
force-pushed
the
deprecate-redundant-property-enabled-focus-mode
branch
from
79a93d8
to
8311a37
Compare
akien-mga
approved these changes
Oct 19, 2020
|
Thanks! |
FIF15
added a commit
to FIF15/godot
that referenced
this pull request
Nov 30, 2020
Restore the default focus mode for MenuButton and LinkButton, since it is different from the default of BaseButton.
HEAVYPOLY
pushed a commit
to HEAVYPOLY/godot
that referenced
this pull request
Dec 14, 2020
Restore the default focus mode for MenuButton and LinkButton, since it is different from the default of BaseButton.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of BaseButton
see #41529 for details
this closes #41529, related to #41576