Disable lights for objects with baked lighting

[JFonS]

Don't apply lighting to objects when they have a lightmap texture and the light is set to BAKE_ALL. This prevents applying the same direct light twice on the same object and makes setting up scenes with mixed lighting much easier.

Addresses godotengine/godot-proposals#1306.

[clayjohn]

Implementation looks great! Just make sure to fill in all the docs before it is merged.

[lawnjelly]

Looks good to me too (with clayjohn's amendments)! 😄 👍

[JFonS]

Updated the PR to add more docs. If the added docs are fine, this should be good to merge for 3.2.4 :)

[Janders1800]

For the sake of consistency I'll report that DirectionalLights still double illuminate backed objects, even wen setup to Bake Mode All. But I can already work with this, great enhancement!

I can open a bug report if you want to track it there.

[mindinsomnia]

For the sake of consistency I'll report that DirectionalLights still double illuminate backed objects, even wen setup to Bake Mode All. But I can already work with this, great enhancement!

I can open a bug report if you want to track it there.

It sounds like a bug to me. I think it'd be worth reporting it.

[Calinou]

For the sake of consistency I'll report that DirectionalLights still double illuminate backed objects, even wen setup to Bake Mode All. But I can already work with this, great enhancement!

I can open a bug report if you want to track it there.

@Janders1800 Can you still reproduce this DirectionalLight issue in 3.2.4beta6?

[Janders1800]

No, it seems to work OK

[Calinou]

@Janders1800 Actually, I was able to reproduce this since I last commented:

test_lightmap.zip

Try making the DirectionalLight visible in main scene included in the above project.

[Janders1800]

Weird, I can reproduce on your project but in mine works ok.
LightMaps.zip

[Calinou]

@Janders1800 Looking at your test project, it seems this feature works as expected in GLES2 but not GLES3. I'll open a new issue about this.