-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PopupMenu unresponsive on right side of menu #41689
Fix PopupMenu unresponsive on right side of menu #41689
Conversation
CC @EricEzaM |
Hi @nathanfranke, @akien-mga. Unfortunately I cannot reproduce the issue on my PR... not sure what is going on - maybe it is a platform specific issue? Anyway, this PR breaks what this piece of code tries to solve - not selecting items when trying to select the scrollbar. See below video of my test. So, the reason this code is required is because of the below situation. The scroll container just renders the scrollbar above the content. This is why I used the control rect initially, as it already accounts for the margin container. However, the scroll container rect would also work, as in my review below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ef06ef1
to
034e123
Compare
I chose option "A" since it seemed more elegant 😄 |
All good on my end after a test, thanks! |
Also fixes #41762. |
Thanks! |
Bugsquad edit: Fixes #41762.