Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaks in GDScript (3.2) #41931

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Fix leaks in GDScript (3.2) #41931

merged 2 commits into from
Sep 24, 2020

Conversation

RandomShaper
Copy link
Member

Version of #41930 for 3.2.

@RandomShaper RandomShaper added this to the 3.2 milestone Sep 9, 2020
akien-mga
akien-mga approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as approved as the master PR was merged.
I'll give it some time for potential regression reports against master before merging, and also in case I need to rush a 3.2.4 hotfix to handle other regressions. So ETA: 1 week.

@akien-mga akien-mga merged commit bca2633 into godotengine:3.2 Sep 24, 2020
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fix_gdscript_leaks_3.2 branch September 24, 2020 07:07
@qarmin qarmin mentioned this pull request Nov 23, 2020
Closed
@DarkMessiah DarkMessiah mentioned this pull request Dec 17, 2020
Closed
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@vnen vnen Awaiting requested review from vnen

@bojidar-bg bojidar-bg Awaiting requested review from bojidar-bg

Assignees
No one assigned
Labels
bug topic:gdscript
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
2 participants
@RandomShaper @akien-mga