Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark InterpolatedCamera as deprecated #42113

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 16, 2020

InterpolatedCamera has already been removed from the master branch. This adds a deprecation notice to inform people about the upcoming removal in Godot 4.0.

Its functionality could be replicated in a GDScript add-on with relative ease.

InterpolatedCamera has already been removed from the `master` branch.
This adds a deprecation notice to inform people about the upcoming removal
in Godot 4.0.

Its functionality could be replicated in a GDScript add-on with relative
ease.
@Calinou Calinou requested a review from a team as a code owner September 16, 2020 13:38
@Calinou Calinou added this to the 3.2 milestone Sep 16, 2020
@akien-mga akien-mga merged commit 2179c85 into godotengine:3.2 Sep 16, 2020
@akien-mga
Copy link
Member

Thanks!

@xavierocampos
Copy link

I commented on Weblate when I saw the comment to be translated, but I also comment here: Why is it removed?

Yes, it's true, you can replicate the function with relative ease, the point is that this node already provided a basic functional behavior for a large number of projects without adding more code or failing that, if you want something more personalized you could always resort to the normal Camera node but remove the InterpolatedCamera node because? was it giving some kind of recognized failure? because if not I don't think it would bother to keep it.

@Calinou
Copy link
Member Author

Calinou commented Sep 26, 2020

@xavierocampos Unlike 2D, 3D camera smoothing is a complex topic. There are more axes and variables to bother about, and different game genres have very different desires for camera smoothing. I don't think we can cover all 3D camera smoothing use cases with a single node.

Either way, I'm working on an add-on that brings InterpolatedCamera3D back. This time however, it has more features that will make it more useful in real world projects.

@xavierocampos
Copy link

@xavierocampos Unlike 2D, 3D camera smoothing is a complex topic. There are more axes and variables to bother about, and different game genres have very different desires for camera smoothing. I don't think we can cover all 3D camera smoothing use cases with a single node.

Either way, I'm working on an add-on that brings InterpolatedCamera3D back. This time however, it has more features that will make it more useful in real world projects.

I agree with what you say, it doesn't cover the needs in any case, but it does in simple cases, if you tell me that you are working on a component that fulfills the same purpose in a more effective way I am more relaxed. I do not deny that it is a component for simple cases but it is good to have something of that style precisely for those simple cases.

@Calinou Calinou deleted the deprecate-interpolatedcamera branch September 30, 2020 20:46
@shackra
Copy link
Contributor

shackra commented Oct 12, 2020

@Calinou what's the URL of the addon or what is its name? I was using this node and caught by surprise by the warning.

@Calinou
Copy link
Member Author

Calinou commented Oct 12, 2020

@shackra https://github.com/Calinou/godot-interpolated-camera3d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants