Add a Tightness parameter to AudioStreamPlayer3D #42358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
cherrypick:3.x
| @@ -474,7 +474,7 @@ void AudioStreamPlayer3D::_notification(int p_what) { | |||
|
|
|||
| //TODO: The lower the second parameter (tightness) the more the sound will "enclose" the listener (more undirected / playing from | |||
There was a problem hiding this comment.
Looks like "TODO:" can now be deleted from the comment.
|
I didn't remove it because a more advanced implementation could change the
tightness based on distance.
…On Sat, 10 Oct 2020, 12:40 IAmActuallyCthulhu, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In scene/3d/audio_stream_player_3d.cpp
<#42358 (comment)>:
> @@ -474,7 +474,7 @@ void AudioStreamPlayer3D::_notification(int p_what) {
//TODO: The lower the second parameter (tightness) the more the sound will "enclose" the listener (more undirected / playing from
Looks like "TODO:" can now be deleted from the comment.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#42358 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHUPIPZLXMFBDW2FC64OEQDSKBB2BANCNFSM4R3DEWLQ>
.
|
Calinou
changed the title
Calinou
changed the title
|
Superseded by #58841. |
akien-mga
added
archived
and removed
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows this parameter for the sound algorithm in AudioStreamPlayer3D to be modified.
I didn't like the fact that an object directly on my left would only play through the left channel with 0 in the right, seemed too artificial for me. Now I can customize it as I like! :)
Bugsquad edit: This closes godotengine/godot-proposals#3384.