Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Disable sanitizer builds until we fix them #42464

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

akien-mga
Copy link
Member

Added in #40994 but without recent rebase, so they don't pass currently.

Added in godotengine#40994 but without recent rebase, so they don't pass currently.
@qarmin
Copy link
Contributor

qarmin commented Oct 1, 2020

Error in CI shows that some commits between this PR branch and current 3.2 branch introduced leak

Direct leak of 72 byte(s) in 1 object(s) allocated from:
    #0 0x7f62d43d4bc8 in malloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10dbc8)
    #1 0xf0103a3 in Memory::alloc_static(unsigned long, bool) core/os/memory.cpp:82
    #2 0xf0102a2 in operator new(unsigned long, char const*) core/os/memory.cpp:42
    #3 0x590910c in MutexPosix::create_func_posix(bool) drivers/unix/mutex_posix.cpp:52
    #4 0xf014a48 in Mutex::create(bool) core/os/mutex.cpp:43
    #5 0x144cc0b in OS_X11::initialize(OS::VideoMode const&, int, int) platform/x11/os_x11.cpp:124
    #6 0x15ba827 in Main::setup2(unsigned long) main/main.cpp:1269
    #7 0x15b54b6 in Main::setup(char const*, int, char**, bool) main/main.cpp:1213
    #8 0x143ec3b in main platform/x11/godot_x11.cpp:49
    #9 0x7f62d2eb20b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

Which as blame shows:
https://github.com/godotengine/godot/blame/8d36b7206cf11607395e68f060f003223ae62a95/platform/x11/os_x11.cpp#L124

probably was caused by this commit #42341

Probably deleting in destructor this mutex will fix issue CC @pouleyKetchoupp

events_mutex = Mutex::create();

@akien-mga
Copy link
Member Author

I'll merge for now to fix CI, but this can be reactivated (remove the if: false) once the regression is fixed.

@akien-mga akien-mga merged commit 01f2348 into godotengine:3.2 Oct 1, 2020
@akien-mga akien-mga deleted the 3.2-ci-disable-sanitizers branch October 1, 2020 14:00
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants