Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix screen_get_dpi on macOS. #42477

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 1, 2020

Fix regression from #40084, diagonal DPI (calculation taken for SDL) seems to give better values than original code before #40084 (at least for one of my displays), but it still a bit off for fractional UI scaling modes. I do not see any way to get precise DPI without using undocumented CoreGraphics private APIs.

Fixes #42474

@bruvzg bruvzg added this to the 4.0 milestone Oct 1, 2020
@bruvzg bruvzg requested a review from a team as a code owner October 1, 2020 20:01
@akien-mga akien-mga merged commit 5e726d8 into godotengine:master Oct 1, 2020
@akien-mga
Copy link
Member

Thanks!

@bruvzg bruvzg deleted the macos_dpi branch November 5, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iMac Retina OS.get_screen_dpi() incorrect in 3.2.3 release
2 participants