Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow adding Objects to the project settings #42616

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 7, 2020

Godot doesn't support serializing objects.

Note: I haven't tested this since I can't open the Project Settings in the current master branch due to a DisplayServer bug (even in single window mode).

This closes #33667.

@Calinou Calinou added bug cherrypick:3.x Considered for cherry-picking into a future 3.x release crash topic:editor labels Oct 7, 2020
@Calinou Calinou added this to the 4.0 milestone Oct 7, 2020
@akien-mga
Copy link
Member

This fails building and should be rebased (and tested).

@KiritoAM
Copy link
Contributor

KiritoAM commented Jan 9, 2021

@Calinou I've tested this on latest and all seems good.
Regarding #33667, I can't repro this issue on latest without your fix - I can select the Object type from the dropdown and try to create a setting, but it fails to create it (and add it to project.godot upon saving the settings). Not sure exactly where it fails to add the setting; it makes it through ProjectSettingsEditor::_add_setting, but the Object value created in the function is nil.
Would be nice to get your change in so avoid this situation.

Godot doesn't support serializing objects.

This closes godotengine#33667.
@Calinou Calinou force-pushed the project-settings-no-object branch from 7ebea3d to 7b84f4f Compare January 10, 2021 14:07
@Calinou
Copy link
Member Author

Calinou commented Jan 10, 2021

Rebased and tested, it works fine to the extent I can test it. (I still can't select options in dropdown menus due to a DisplayServer regression.)

@KiritoAM
Copy link
Contributor

The IOS build failure doesn't look like it has anything to do with your change. Guessing the procedure in this situation is to just restart the build and hope the build machine doesn't trip over again?

@akien-mga akien-mga merged commit 43ab640 into godotengine:master Jan 11, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 12, 2021
@Calinou Calinou deleted the project-settings-no-object branch March 31, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding ProjectSettings value with TYPE_OBJECT make Godot Project unrecognizable
3 participants