Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Image.load_bmp_from_buffer() for run-time BMP image loading #42947

Merged
merged 1 commit into from
Nov 7, 2020

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Oct 20, 2020

This partially addresses godotengine/godot-proposals#676.

Demo project: test_bmp_exr_loading.zip
As you can see in the demo project, I've also included a run-time OpenEXR loading example. However, I stripped OpenEXR loading from the PR as it increased the binary size for export templates noticeably (+115 KB for a release LTO'd Linux 64-bit export template).

@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:core labels Oct 20, 2020
@Calinou Calinou added this to the 4.0 milestone Oct 20, 2020
@Calinou Calinou force-pushed the image-load-bmp-from-buffer branch from 05be917 to 0209e37 Compare October 20, 2020 21:52
@Calinou Calinou requested a review from a team as a code owner October 20, 2020 21:52
@akien-mga akien-mga merged commit 329d2c1 into godotengine:master Nov 7, 2020
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 11, 2020
@Calinou Calinou deleted the image-load-bmp-from-buffer branch March 31, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants