-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DirectionalLight2D #43297
Implement DirectionalLight2D #43297
Conversation
f93b8b7
to
92d1ccf
Compare
As for the naming, if PointLight2D turns out to be too confusing or difficult to search for, I think we could name it OmniLight2D for consistency with 3D. Sure, you can also use PointLight2D to create spotlights, but you can also do that in 3D by adding a projector texture that makes your OmniLight3D look like a SpotLight3D. |
92d1ccf
to
ac9ff1b
Compare
@Calinou The problem is that, most nodes in 2D and 3D work the same and have the same options when they have the same name. PointLight2D works quite different to OmniLight3D and SpotLight3D. At much it could be renamed to PositionalLight2D, but I think Point makes more sense. |
937fc03
to
99d349b
Compare
There is something wrong with More specifically, if you change the |
TextureLight2D could work if it depends on the texture, however PointLight2D is I'd say ok. |
Also separated Light2D in PointLight2D and DirectionalLight2D. Used PointLight2D because its more of a point, and it does not work the same as OmniLight (as shape depends on texture). Added a few utility methods to Rect2D I needed.
99d349b
to
f123981
Compare
Thanks! |
Also separated Light2D in PointLight2D and DirectionalLight2D.
Used PointLight2D because its more of a point, and it does not work
the same as OmniLight (as shape depends on texture).
Added a few utility methods to Rect2D I needed.