Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SO_REUSEADDR for UDP. #43918

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Nov 27, 2020

It allows binding multiple sockets to the same ADDR:PORT (unlike TCP,
which still requires different ADDR:PORT combinations).

Fixes #43912

Note: I didn't add the platform code because it likely affects all platforms except windows (indeed, all BSD socket implementations).

It allows binding multiple sockets to the same ADDR:PORT (unlike TCP,
which still requires different ADDR:PORT combinations).
@Faless Faless added bug topic:network cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Nov 27, 2020
@Faless Faless added this to the 4.0 milestone Nov 27, 2020
@akien-mga akien-mga merged commit 0ffa06b into godotengine:master Nov 27, 2020
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PacketPeerUDP.listen reuses port without error on Linux
2 participants