Don't box params on Native->C# calls with Variant params #44106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Dec 5, 2020
akien-mga
reviewed
Dec 5, 2020
| @@ -38,15 +38,16 @@ | |||
| class GDMonoMethod : public IMonoClassMember { | |||
| StringName name; | |||
|
|
|||
| int params_count; | |||
| uint16_t params_count; | |||
There was a problem hiding this comment.
It's always initialized in the constructor, in the call to update the method signature. Is there a performance penalty in adding a default value here?
akien-mga
reviewed
Dec 5, 2020
neikeq
force-pushed
the
mono-invoke-no-params-boxing
branch
from
4283a82
to
ed46171
Compare
Godot uses Variant parameters for calls to script methods. Up until now we were boxing such parameters when marshalling them for invokation, even if they were value types. Now Godot allocates the marshalled parameters on the stack, reducing the GC allocations resulted from boxing.
neikeq
force-pushed
the
mono-invoke-no-params-boxing
branch
from
ed46171
to
a946f84
Compare
akien-mga
approved these changes
Dec 6, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Godot uses Variant parameters for calls to script methods. Up until now we were boxing such parameters when marshalling them for invokation, even if they were value types.
Now Godot allocates the marshalled parameters on the stack, reducing the GC allocations resulted from boxing.