Overridden properties link to definition in Godot Docs #44187
Conversation
joshdegraw
changed the title
joshdegraw
changed the title
joshdegraw
changed the title
|
I had to take some time due to a house flood, but I am planning on finishing this PR ASAP. |
author Josh DeGraw <joshmdegraw@gmail.com> 1607276564 -0700 committer Josh DeGraw <joshmdegraw@gmail.com> 1616823155 -0600 parent c6b9cea author Josh DeGraw <joshmdegraw@gmail.com> 1607276564 -0700 committer Josh DeGraw <joshmdegraw@gmail.com> 1616822970 -0600 Add XML attribute to reference top level parent that defines overridden properties. Modify makerst.py to use the new changes. Add XML attribute to reference top level parent that defines overridden properties. Sync classes reference template with current code base Add inherits to PackedSceneGLTF.xml. Modify makerst.py to use the new changes. Modify makerst.py to use the new changes. Fix clang formatting error.
joshdegraw
force-pushed
the
overrides-link-to-parent
branch
from
f05c91c to
19d9bd3
Compare
|
I kept the "overridden" property in the PropertyDoc struct in doc_data.h. Everything appears to be working. I looked for other things that utilize the overridden property and couldn't find anything. If we're happy with that being removed, I can go ahead and amend my commit to remove that property from the struct, otherwise this PR can be accepted as everything appears to be working. |
|
@Calinou Only asking since I've seen your eyes on this PR-- is there anything I need to do in order to get this merged? |
You need to rebase it against the latest |
|
Bump :) |
|
Superseded by #55559. Thanks for your contribution nonetheless! You've been attributed in the new PR for your efforts. |
This is the in-progress implementation of godotengine/godot-docs#4432
Right now the XML generator has been modified to contain the new data, and I am now in the process of editing makerst.py to format it properly.