Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash parsing a serialized Reference #44452

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Fix crash parsing a serialized Reference #44452

merged 1 commit into from
Dec 17, 2020

Conversation

RandomShaper
Copy link
Member

Yet another case of a Reference being referenced too late.

Fixes #44447.

NOTE: Submitting separare version for 3.2 (since local cherry-picking failed).

@RandomShaper RandomShaper added this to the 4.0 milestone Dec 17, 2020
@RandomShaper RandomShaper mentioned this pull request Dec 17, 2020
Merged
@akien-mga akien-mga merged commit f47ef03 into godotengine:master Dec 17, 2020
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fix_crash_parsing_ref branch December 17, 2020 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@vnen vnen Awaiting requested review from vnen

@reduz reduz Awaiting requested review from reduz

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Resource loading crashes editor 3.2.4 beta 4
2 participants
@RandomShaper @akien-mga