Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Add animation reset track feature #44558

Merged
merged 2 commits into from
May 9, 2021

Conversation

RandomShaper
Copy link
Member

@RandomShaper RandomShaper commented Dec 20, 2020

Version of #43115 for 3.x.

Probably this would be worth merging just once 3.2.4 is out, because it may benefit from some testing so both 4.0 and 3.2.5 can benefit from any fixes for issues discovered on it.

UPDATE: When #45810 is fixed for 4.0, the fix will be integrated here. Switching to draft until that happens. Done.

@RandomShaper RandomShaper added this to the 3.2 milestone Dec 20, 2020
@RandomShaper RandomShaper requested a review from a team as a code owner December 20, 2020 23:20
@akien-mga akien-mga requested a review from a team January 15, 2021 15:54
@RandomShaper RandomShaper marked this pull request as draft February 8, 2021 01:30
@RandomShaper RandomShaper marked this pull request as ready for review February 9, 2021 20:46
@RandomShaper RandomShaper requested a review from a team as a code owner March 12, 2021 12:26
Base automatically changed from 3.2 to 3.x March 16, 2021 11:11
@aaronfranke aaronfranke modified the milestones: 3.2, 3.3 Mar 16, 2021
@akien-mga akien-mga modified the milestones: 3.3, 3.4 Mar 26, 2021
@akien-mga akien-mga changed the title Add animation reset track feature (3.2) [3.x] Add animation reset track feature Mar 26, 2021
As a bonus, to have consistency between use Beziers and create insert tracks, use Beziers also gets a default via editor settings that is used when the confirmation dialog is disabled, instead of just falling back to creating non-Bezier tracks.
@RandomShaper
Copy link
Member Author

Rebased!

@akien-mga akien-mga merged commit 4730856 into godotengine:3.x May 9, 2021
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the reset_track_3.2 branch May 27, 2021 15:55
@Torguen
Copy link

Torguen commented Jul 27, 2021

I have no idea what this suggestion consists of, there is no information about it. Only in the title something is said minimally but no details.

@akien-mga
Copy link
Member

Check the master pull request which was linked in the first post:

Version of #43115 for 3.x.

@sosasees
Copy link

in most of my AnimationPlayer nodes before this feature existed,
the first thing i did before animating any previously unanimated property
was to add the initial state of that property to a single-frame animation which I always liked to name "Start" or "Init" or "Idle".

now this feature is automating this task by its own "Reset" animation.
this is something i didn't know i needed until i read it in the changelog and got excited.

thank you for this feature.

@chucklepie
Copy link

chucklepie commented Jan 1, 2022

Maybe I'm being a bit dumb, I'm on latest 3.4.2 but I have absolutely no idea how to use this. Create a new or existing animation player and 'apply reset' is greyed out an no 'RESET' animation is created. Create a new animation with properties and add a key frame, 'apply reset' is blank and no new 'RESET' animation is created. I add a new animation called 'RESET' and it makes it a reset showing the reset icon but it's blank. Repeat the above and nothing happens, it's still blank.

I thought I read 'RESET' is auto-created on first save as I have reset on save set, nothing happens for me.

I read about 'Create Reset Track(s)', but this is nowhere to be found.

@Calinou
Copy link
Member

Calinou commented Jan 1, 2022

@chucklepie The RESET track should not be created manually. The editor will ask you to create it automatically when you insert a new track in an existing animation by clicking the key icon next to a property in the inspector. Inserting a new key in an existing track will not make this dialog appear.

@chucklepie
Copy link

Ah, when I create a track I usually do it the longer way - 'add track' then select the node then select property. How is this different to clicking the key icon as they both do the same thing, but only one adds a reset entry?

@Calinou
Copy link
Member

Calinou commented Jan 1, 2022

Ah, when I create a track I usually do it the longer way - 'add track' then select the node then select property. How is this different to clicking the key icon as they both do the same thing, but only one adds a reset entry?

This is a known issue, see #55438.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants