[3.2] Fix the String::get_base_dir() logic to properly check for top level directories on Windows
#44610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l directories on Windows.
m4gr3d
changed the title
String::get_base_dir() logic to properly check for top level directories on WindowsString::get_base_dir() logic to properly check for top level directories on Windows
akien-mga
approved these changes
Dec 23, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a path like
D:\, the previous logic would check for://and not find it.This caused it to fall into a case where the returned base directory would be built based on the last
\\or/character, in this case causingD:to be returned.Fixes issue #44409.
master PR