Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an OS.get_thread_caller_id() method #44732

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Dec 27, 2020

This can be used to print thread IDs in logs. This can make it easier to debug multi-threaded applications.

This closes godotengine/godot-proposals#2026.

Thanks @Khaos66 for providing an implementation 🙂
I renamed OS.get_caller_id() from their implementation to OS.get_thread_caller_id() to make it more explicit.

@Calinou Calinou requested a review from a team as a code owner December 27, 2020 15:52
@Calinou Calinou added enhancement topic:core cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Dec 27, 2020
@Calinou Calinou added this to the 4.0 milestone Dec 27, 2020
This can be used to print thread IDs in logs. This can make it easier
to debug multi-threaded applications.

Co-authored-by: Khaos <khaos@khaos-coders.org>
@Calinou Calinou force-pushed the os-add-get-thread-caller-id branch from 31bcd67 to 35b046d Compare December 27, 2020 15:54
@akien-mga akien-mga merged commit d6765c8 into godotengine:master Jan 26, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.2.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 26, 2021
@Calinou Calinou deleted the os-add-get-thread-caller-id branch March 31, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose thread IDs to scripting
2 participants