Batching - fix ninepatch proxy textures (e.g. animated) #44790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Dec 29, 2020
lawnjelly
force-pushed
the
ewok_ninepatch_proxy
branch
from
b3126de
to
0ee2743
Compare
Ninepatch code has a check to prevent use of zero sized textures. This didn't deal properly with animated textures, which use a proxy (link to another texture). This PR uses a generalised method of getting textures, with built in support for proxy textures and protection against infinite loops.
lawnjelly
force-pushed
the
ewok_ninepatch_proxy
branch
from
0ee2743
to
1e99e89
Compare
akien-mga
approved these changes
Dec 29, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ninepatch code has a check to prevent use of zero sized textures. This didn't deal properly with animated textures, which use a proxy (link to another texture). This PR fixes that.
EDIT - I've now made this generalised to apply to all canvas textures and properly deal with proxys, with protection against infinite loop. Decided that would be better after all than having localized changes.
Fixes #44770