-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the page size for array/dictionary editors to 20 #44864
Increase the page size for array/dictionary editors to 20 #44864
Conversation
Why not an editor setting? I know they are a bit bloated atm but this seems like a good one to have actually. |
7aa4462
to
5be0e70
Compare
@EricEzaM I added a setting for it, which you can configure between 10 and 100 (defaults to 50). The setting change applies when you select a node – no need to restart the editor. |
I'm fine with making this configurable, but isn't 50 a lot? I'm not concerned about performance but about usability, if you have an exported array or dictionary and expand it, it will push all other node properties very far to the end of the scroll bar. I'm not sure that's better than the current experience to have a paged editor with 10 entries per page, which still lets you access other properties in the same/next "screen". |
Discussed it with @reduz, we agree that 20 would be a better default value. If you need to edit arrays with more than 20 items, chances are that using the inspector is not the best workflow and it would be better to edit them nicely formatted in GDScript or have them serialized in JSON or ConfigFile resources. |
5be0e70
to
764cd98
Compare
With smaller arrays/dictionaries, this makes it possible to view all of an array/dictionary's items on a single page. Larger values could be used, but make switching between node selections quite slow, especially on low-end CPUs. They could also be problematic with complex resource inspectors for arrays/dictionaries that contain Resources. This closes godotengine/godot-proposals#2058.
764cd98
to
d97d65b
Compare
I've changed the default number of items per page to 20. It can still be increased up to 100 in the Editor Settings. |
Thanks! |
Cherry-picked for 3.2.4. |
With smaller arrays/dictionaries, this makes it possible to view all of an array/dictionary's items on a single page.
Larger values could be used, but make switching between node selections quite slow, especially on low-end CPUs. They could also be problematic with complex resource inspectors for arrays/dictionaries that contain Resources.
The change is trivially cherry-pickable to
3.2
and has been tested there.This closes godotengine/godot-proposals#2058.