Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix freeze-crash in lightmapper under MinGW-GCC (3.2) #45346

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

RandomShaper
Copy link
Member

Why not another attempt at fixing #45097?

I've found a non-hacky way to emit the PAUSE instruction, via an intrinsic that seems to work. Something feels different... The Preparing data structures step now is almost immediate.

I've tested with one more project this time.

@akien-mga, a couple of remarks:

  • I'm not actually building on Fedora, but on Windows with MinGW-w64. I know the results may vary, but they seem to be very similar most of the time.
  • I've "reconciled" the new patch with the stored one manually, so the patch file may be wrong. (Reverse-applying the patch in order to get a new one with all the changes didn't work for me; I don't know why.) I guess if this works we can take care of that later.

@akien-mga
Copy link
Member

You're amazing :D
I'll throw a build with that PR to get another round of testing from our trustworthy crash-testers :)

@akien-mga akien-mga merged commit 9d1d4d1 into godotengine:3.2 Jan 21, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

I'm not actually building on Fedora, but on Windows with MinGW-w64. I know the results may vary, but they seem to be very similar most of the time.

For the reference, what MinGW and GCC versions do you have? You might have newer ones than I have on Fedora (MinGW 7.0.0 and GCC 10.2) which might have solved some of the alignment issues reported upstream?

@RandomShaper
Copy link
Member Author

@akien, build-info.txt

@akien-mga akien-mga modified the milestones: 3.2, 3.3 Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants