Fix C# bindings generator for default value types #45424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
cs-bindings
branch
from
45d0223
to
016cf21
Compare
aaronfranke
force-pushed
the
cs-bindings
branch
from
016cf21
to
ada67ab
Compare
neikeq
approved these changes
Feb 25, 2021
aaronfranke
force-pushed
the
cs-bindings
branch
from
ada67ab
to
4b4721f
Compare
|
Thanks! |
This was referenced Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #34668 is taking forever to be reviewed, I copied the C# fixes to this PR so that they can be reviewed and merged separately. The code in #34668 is slightly different, so #34668 will have to be rebased on top of this later. CC @neikeq.
This can be cherry-picked to 3.2 manually (I have a branch saved locally), it technically breaks compatibility, but only if projects relied on broken behavior.