Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes crash when exiting with --verbose with leaked resources #45853

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Fixes crash when exiting with --verbose with leaked resources #45853

merged 1 commit into from
Feb 9, 2021
+2 −2

Conversation

groud
Copy link
Member

@groud groud commented Feb 9, 2021

Fixes #44850.

@groud groud added this to the 4.0 milestone Feb 9, 2021
@groud
Copy link
Member Author

groud commented Feb 9, 2021

cc @Calinou

Calinou
Calinou approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think it makes sense to always flush on every line if the ProjectSettings singleton isn't available.

@akien-mga akien-mga merged commit 7d9eed0 into godotengine:master Feb 9, 2021
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou mentioned this pull request Feb 13, 2021
Merged
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 14, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.2.4. (As part of the #44393 cherry-pick commit.)

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Godot crash when printing info about leaked nodes due to optional forced flush
3 participants
@groud @akien-mga @Calinou