Refactor Process Mode #46191
Refactor Process Mode #46191
Conversation
There was a problem hiding this comment.
Missing the renaming of SceneTreeTimer's is_pause_mode_process, since it's now called process mode, not pause mode.
Missing documentation. EDIT: I can add this though, I already have similar documentation written for #39606.
| PROCESS_MODE_NORMAL, // process only if not paused | ||
| PROCESS_MODE_PAUSE_ONLY, // process only if paused | ||
| PROCESS_MODE_ALWAYS, // process always | ||
| PROCESS_MODE_DISABLED, // never process |
There was a problem hiding this comment.
Shouldn't this one be called PROCESS_MODE_NEVER, if it's the opposite of ALWAYS?
There was a problem hiding this comment.
Maybe because Never sounds too irreversible?
Disabled would suggest the possibility to (re-)activate it when requested?
There was a problem hiding this comment.
If DISABLED is kept, then ALWAYS should be changed to ENABLED for consistency.
There was a problem hiding this comment.
I think current naming is more intuitive.
edit: changed it
Implements godotengine/godot-proposals#1835 (comment) * PauseMode is now ProcessMode, containing the following states: ``` PROCESS_MODE_INHERIT, // same as parent node PROCESS_MODE_NORMAL, // process only if not paused PROCESS_MODE_PAUSE_ONLY, // process only if paused PROCESS_MODE_ALWAYS, // process always PROCESS_MODE_DISABLED, // never process ``` * NOTIFICATION_PAUSED and NOTIFICATION_UNPAUSED are received effectively when the node is paused and unpaused (not any longer when pause mode is set in SceneTree). * Renamed some nodes that used ProcessMode/process_mode to specify a callback type to ProcessCallback to avoid clashes.
reduz
force-pushed
the
refactor-process-mode
branch
from
92be794
to
083aa9b
Compare
| if (p.name == "script") { | ||
| category_vbox = nullptr; // script should go into its own category | ||
| } | ||
|
|
There was a problem hiding this comment.
Doesn't look like related to this PR.
There was a problem hiding this comment.
It fixes a bug where the script appears above the process mode property, so I fixed it here.
There was a problem hiding this comment.
I'm not convinced that this is 100% ideal, but it's not confusing and it's much better than the current system, so I will give this a ✔️
I can add documentation and do the SceneTreeTimer rename I mentioned, I'll rebase #39606 on top of this PR.
|
Thanks! |
Implement PR: godotengine/godot#46191
Implement PR: godotengine/godot#46191
Implements godotengine/godot-proposals#1835 (comment) , extending the pause functionality to a more generic process mode. This allows disabling of nodes, as well as their children.
Keep in mind that disabling nodes only affects the logic, and does not hide them. This goes separate to the visual part.
NOTIFICATION_PAUSEDandNOTIFICATION_UNPAUSEDare received effectively when the node is paused and unpaused (not any longer when pause mode is set in SceneTree).Obligatory Screenshot: