[3.x] Add GDNative Framework support for macOS, add Unix symlink API. #46860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
changed the title
akien-mga
changed the title
bruvzg
force-pushed
the
symlinks_and_macos_gdn_framework_export
branch
2 times, most recently
from
9b847c7
to
a68e8f8
Compare
bruvzg
force-pushed
the
symlinks_and_macos_gdn_framework_export
branch
from
a68e8f8
to
15e62c3
Compare
akien-mga
approved these changes
May 22, 2021
bruvzg
force-pushed
the
symlinks_and_macos_gdn_framework_export
branch
2 times, most recently
from
ba5a03e
to
688158e
Compare
akien-mga
approved these changes
May 24, 2021
bruvzg
force-pushed
the
symlinks_and_macos_gdn_framework_export
branch
from
688158e
to
53f05c9
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to select, load and export (both
.dmgand.zip) macOS ".frameworks" as GDNative libraries.Adds minimal symlink API to
DirAccess(frameworks usually contain multiple relative symlinks).Framework export won't work from Windows (If there are symlinks in the framework). NTFS have support for symlinks, but I do not see any way to get relative symlink target path, all functions seems to return full path. And creating symlinks seems to require privilege elevation. Not sure what to do with it (currently it will print a warning).
Same as #46866 for 3.2.