print_stray_nodes() also prints node's script #47170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hilfazer
force-pushed
the
print_stray_nodes
branch
from
58b4082
to
2d70ee6
Compare
akien-mga
force-pushed
the
3.x
branch
2 times, most recently
from
71cb8d3
to
c58391c
Compare
akien-mga
force-pushed
the
print_stray_nodes
branch
from
2d70ee6
to
fe21fb1
Compare
|
Rebased to solve merge conflicts. |
akien-mga
approved these changes
Jul 2, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes print_stray_nodes() a bit more useful by also printing their scripts if any are attached.
On the screenshot we can see an unnamed node of type Node. It can be difficult to track where it was created. Knowing its script helps with that.
The PR is for 3.x only because on master branch Godot hangs* if any of the stray nodes has a script. I wasn't able to determine what causes this.
*Godot hangs in case print_stray_nodes() is called by a tool script in the editor. Otherwise only the game hangs.