[HTML5] Disable body_size in fetch. #47597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using `Content-Length` from the server when `Content-Encoding` was not set (i.e. response was not compressed). Sadly, in CORS requests accessing headers is restricted, and while `Content-Length` is enabled by default, `Content-Encoding` is not. This results in the impossibility of knowing if the content was compressed, unless the server explicitly enabled the encoding header via `Access-Control-Expose-Headers`. To keep maximum compatibility we must disable `body_size` completely.
Faless
added
bug
platform:web
topic:porting
topic:network
cherrypick:3.x
akien-mga
approved these changes
Apr 5, 2021
|
Thanks! |
|
Cherry-picked for 3.3. |
akien-mga
removed
the
cherrypick:3.x
This was referenced Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
Content-Lengthfrom the server whenContent-Encodingwas not set (i.e. response was not compressed).
Sadly, in CORS requests accessing headers is restricted, and while
Content-Lengthis enabled by default,Content-Encodingis not.This results in the impossibility of knowing if the content was
compressed, unless the server explicitly enabled the encoding header
via
Access-Control-Expose-Headers.To keep maximum compatibility we must disable
body_sizecompletely.Fixes heroiclabs/nakama-godot#66
Allowed headers: https://developer.mozilla.org/en-US/docs/Glossary/CORS-safelisted_response_header