Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a subtle background to editor scrollbars #47633

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Apr 5, 2021

This makes it possible to see whether a scrollbar grabber is at the top or at the bottom of a scrollbar. Also, if a scrollable area is very large, this makes it easier to notice that the area can be scrolled (since the grabber is proportionally very small).

The scrollbar grabbers were also made thicker and slightly more opaque for better visibility, especially in peripheral vision.

This can be merged independently of #45607.

Preview

Before

Before

After

After

This makes it possible to see whether a scrollbar grabber is at the top
or at the bottom of a scrollbar. Also, if a scrollable area is very
large, this makes it easier to notice that the area can be scrolled
(since the grabber is proportionally very small).

The scrollbar grabbers were also made thicker and slightly more opaque
for better visibility, especially in peripheral vision.
@Calinou Calinou requested a review from a team as a code owner April 5, 2021 00:06
@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:editor usability labels Apr 5, 2021
@Calinou Calinou added this to the 4.0 milestone Apr 5, 2021
Copy link
Member

@fire fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. The current state without the gradient makes it hard to know where the scroll bar position is.

@akien-mga akien-mga merged commit de3b3e1 into godotengine:master Apr 5, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.3.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 6, 2021
@Calinou Calinou deleted the editor-theme-scrollbar-add-background branch August 3, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants