Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dummy scene during saving #47828

Closed
wants to merge 1 commit into from
Closed

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Apr 12, 2021

Fixes #43156

Might reintroduce #7976, but to me it looks very similar to #7984, which isn't fixed, so not sure ¯\_(ツ)_/¯

@KoBeWi KoBeWi added bug topic:editor needs testing cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Apr 12, 2021
@KoBeWi KoBeWi added this to the 4.0 milestone Apr 12, 2021
@YuriSizov

This comment has been minimized.

@KoBeWi KoBeWi changed the title Removed duimmy scene during saving Removed dummy scene during saving Apr 12, 2021
@RandomShaper
Copy link
Member

I've opened #49570, that addresses the root cause –if my hyptohesis is correct–, but also has some risk of adding regressions (different from the ones that may be introduced by this one).

My suggestion on how to proceed would be try to validate mine and only if that's not possible or it's found to be wrong, come back to this one and try to confirm it doesn't add regressions.

@akien-mga
Copy link
Member

Superseded by #49570.

@akien-mga akien-mga closed this Jun 15, 2021
@akien-mga akien-mga added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Jun 15, 2021
@KoBeWi KoBeWi deleted the kill_dummy branch June 19, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving complex scene with multiple exports var statements and instanced sub-scenes takes up to minutes
4 participants