[3.x] Style: Enforce braces around if blocks and loops #48475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
akien-mga
force-pushed
the
3.x-style-changes
branch
7 times, most recently
from
ed3b6c2
to
4f0c306
Compare
Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
akien-mga
force-pushed
the
3.x-style-changes
branch
from
4f0c306
to
140350d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #48447 and #48454 to modernize the
3.xbranch and fit the style used inmaster.Note: This was done with
clang-tidy(+ fixing its often bogus changes manually) and therefore it only affects the code which I was compiling (p=x11 tools=yes target=debug). So there's still missing braces in other platform-specific code and within some preprocessor defines which were not set in my local build. If anyone wants to fix what was missed here, feel free to, but having a perfectly harmonious style is not a priority for3.x, so such effort is best spent onmaster.