Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the animation bezier editor #48572

Merged
merged 1 commit into from
Aug 14, 2021
Merged

Improve the animation bezier editor #48572

merged 1 commit into from
Aug 14, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 9, 2021 •
edited
Loading

  • Allow snapping bezier handles to the timeline.
  • Allow precise snapping when holding Shift for keyframes and handles.
    • Previously, it was only allowed for seeking the timeline.
    • This change also impacts the animation track editor, not just the bezier editor.
  • Invert the Ctrl + mouse wheel behavior to match the zoom direction in the animation track editor.
  • Increase the line spacing between the "Time:" and "Value:" texts to improve readability.
  • Tweak box selection styling to match the animation track editor.
  • Adjust line widths for hiDPI displays.

@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release enhancement topic:editor usability labels May 9, 2021
@Calinou Calinou added this to the 4.0 milestone May 9, 2021
@Calinou Calinou force-pushed the improve-animation-bezier-editor branch from 86b2ff3 to e73bec8 Compare May 9, 2021 08:06
@TokageItLab
Copy link
Member

Are there any plans for vertical zoom? It is very difficult to control the handles when the values are small.

@Calinou
Copy link
Member Author

Calinou commented May 9, 2021 •
edited
Loading

Are there any plans for vertical zoom? It is very difficult to control the handles when the values are small.

From my testing on master, vertical zoom is already implemented. Use the mouse wheel without holding down Ctrl on the Bézier area itself (not the timeline).

@TokageItLab
Copy link
Member

TokageItLab commented May 9, 2021 •
edited
Loading

Ah, thank you. I use Mac often so didn't notice that. It might be better to have an indicator like the horizontal scroll.

@Calinou Calinou mentioned this pull request May 9, 2021
Merged
@fire
Copy link
Member

fire commented Jun 4, 2021

Can you update this? I want to review this on master.

@Calinou
Copy link
Member Author

Calinou commented Jun 4, 2021

Can you update this? I want to review this on master.

Rebased.

@Calinou Calinou force-pushed the improve-animation-bezier-editor branch from e73bec8 to a9f67d6 Compare June 4, 2021 22:39
@reduz
Copy link
Member

reduz commented Jun 8, 2021

Pics appreciated

@Calinou
Improve the animation bezier editor
4a4d977 
- Allow snapping bezier handles to the timeline.
- Allow precise snapping when holding Shift for keyframes and handles.
  - Previously, it was only allowed for seeking the timeline.
  - This change also impacts the animation track editor,
    not just the bezier editor.
- Invert the Ctrl + mouse wheel behavior to match the zoom direction
  in the animation track editor.
- Increase the line spacing between the "Time:" and "Value:" texts
  to improve readability.
- Tweak box selection styling to match the animation track editor.
- Adjust line widths for hiDPI displays.
@Calinou
Copy link
Member Author

Calinou commented Aug 14, 2021 •
edited
Loading

Pics appreciated

Here's the increased spacing between "Time" and "Value" when dragging a key:

image

And the box selection styling change:

image

The rest of the changes aren't easily visible in a screenshot or a video.

@Calinou Calinou force-pushed the improve-animation-bezier-editor branch from a9f67d6 to 4a4d977 Compare August 14, 2021 20:30
@akien-mga akien-mga merged commit 8781c95 into godotengine:master Aug 14, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Aug 18, 2021
@Calinou Calinou deleted the improve-animation-bezier-editor branch August 18, 2021 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reduz reduz reduz approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor usability
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Calinou @TokageItLab @fire @reduz @akien-mga