Upgrade Embree to the latest official release (3.13.0). #48885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JFonS
added
bug
topic:thirdparty
regression
cherrypick:3.x
akien-mga
changed the title
akien-mga
approved these changes
May 20, 2021
JFonS
force-pushed
the
upgrade_embree
branch
7 times, most recently
from
2333eeb
to
39ee5d5
Compare
Since Embree v3.13.0 supports AARCH64, switch back to the official repo instead of using Embree-aarch64. `thirdparty/embree/patches/godot-changes.patch` should now contain an accurate diff of the changes done to the library.
|
Thanks! |
|
I'll do a dedicated PR and test build of a 3.x cherry pick to confirm that mingw Windows builds are ok. |
akien-mga
removed
cherrypick:3.3
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Embree v3.13.0 supports AARCH64, switch back to the official repo instead of using Embree-aarch64.
thirdparty/embree/patches/godot-changes.patchshould now contain an accurate diff of the changes done to the library.This should also fix #48822, could be nice to do a test build before merging.