Add support for controlling physics nodes' behavior when disabled #49834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This needs more docs. What does "remove from simulation" mean? can they be readded? |
They are automatically re-added when the node is enabled again. I'll update the doc to make it clear. |
pouleyKetchoupp
force-pushed
the
physics-disable-modes
branch
from
027d70f
to
b0b397c
Compare
akien-mga
reviewed
Jun 30, 2021
doc/classes/CollisionObject2D.xml
Outdated
| @@ -269,6 +269,9 @@ | |||
| <member name="input_pickable" type="bool" setter="set_pickable" getter="is_pickable" default="true"> | |||
| If [code]true[/code], this object is pickable. A pickable object can detect the mouse pointer entering/leaving, and if the mouse is inside it, report input events. Requires at least one [code]collision_layer[/code] bit to be set. | |||
| </member> | |||
| <member name="on_disable" type="int" setter="set_on_disable" getter="get_on_disable" enum="CollisionObject2D.DisableMode" default="0"> | |||
There was a problem hiding this comment.
Wouldn't disable_mode be a clearer name? on_disable sounds like a signal callback.
There was a problem hiding this comment.
I second disable_mode probably being best
There was a problem hiding this comment.
Yes, this name does sound better! Just pushed with this change.
pouleyKetchoupp
force-pushed
the
physics-disable-modes
branch
from
b0b397c
to
cf3a9f4
Compare
New property disable_mode to set different behaviors: Remove: remove from physics simulation MakeStatic: change body mode to static (doesn't affect area and soft body) KeepActive: do nothing Extra change: Handle disable/enable node state with specific notifications, in order to differentiate global pause from disabled nodes.
pouleyKetchoupp
force-pushed
the
physics-disable-modes
branch
from
cf3a9f4
to
5cbdc7a
Compare
akien-mga
approved these changes
Jun 30, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New property
on_disabledisable_modeinCollisionObject2DandCollisionObject3Dto set different behaviors when processing is disabled:Remove: remove from physics simulationMakeStatic: change body mode to static (doesn't affect area and soft body)KeepActive: do nothingSame property on
SoftBody3Dwith onlyRemoveandKeepActivemodes.Extra change in
Node:Handle disable/enable node state with specific notifications, in order to differentiate global pause from disabled nodes.
Implements godotengine/godot-proposals#2843
Supersedes #46921