-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GDNative libraries to Android custom Gradle builds #49911
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks straightforward! I'm wondering if we need to delete the added so
files on rebuild. Otherwise it seems like a previously added so
file might continue to be included in the generated binary even if it's removed from the project.
I thought about that. The problem is, it's impossible to tell what library has been removed, and we don't want to simply remove all the libraries, because the user may, as part of their custom build, be including other libraries manually. |
We could include a .json file (or equivalent) in the export folder that lists the GDNative library files that have been included, so on rebuild the process can know which files to remove. |
Updated to use a JSON to store copied |
Thanks! |
Currently, GDNative libraries are not being copied into the custom build project directories when doing an Android Custom Build. The files are simply ignored:
godot/platform/android/export/gradle_export_util.h
Lines 103 to 105 in c8444c3
This PR ensures the GDNative libraries are copied to the correct directory; so that they're automatically included when Gradle builds the project.
Fixes #49878