Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ring emitter for 4.0 #50370

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Conversation

QbieShay
Copy link
Contributor

@QbieShay QbieShay commented Jul 11, 2021

and 3D CPU particles. The new emitter is called "ring"
and it can emit either in a ring or cylinder fashion.
This adds the following properties for the emitter:

  1. emission_ring_axis: the axis along which the ring/cylinder
    will be constructed
  2. emission_ring_radius: outer radius of the ring/cylinder
  3. emission_ring_inner_radius: inner radius of the cylinder.
    when set to zero, particles will emit in the full volume.
  4. emission_ring_height: height of the ring/cylinder emitter.

This has already been implemented for 3.x, took me a while to get to 4.0. Apologies >.<

3.0 PR:#47801

@QbieShay QbieShay requested review from a team as code owners July 11, 2021 15:14
@QbieShay QbieShay force-pushed the circle-emitter-particle branch 2 times, most recently from d262be5 to f50ab78 Compare July 11, 2021 15:24
@QbieShay QbieShay changed the title This commits adds a new emitter type for particles material Ring emitter for 4.0 Jul 11, 2021
and 3D CPU particles. The new emitter is called "ring"
and it can emit either in a ring or cylinder fashion.
This adds the following properties for the emitter:
1. emission_ring_axis: the axis along which the ring/cylinder
    will be constructed
2. emission_ring_radius: outer radius of the ring/cylinder
3. emission_ring_inner_radius: inner radius of the cylinder.
    when set to zero, particles will emit in the full volume.
4. emission_ring_height: height of the ring/cylinder emitter.
@akien-mga akien-mga merged commit d42f6f4 into godotengine:master Jul 21, 2021
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants