Improve Control's theme item methods documentation
#50429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
force-pushed
the
classref-get-theme-items
branch
from
8e4eb69
to
f01d007
Compare
AaronRecord
suggested changes
Jul 13, 2021
YuriSizov
force-pushed
the
classref-get-theme-items
branch
from
f01d007
to
21b994a
Compare
AaronRecord
approved these changes
Jul 13, 2021
akien-mga
approved these changes
Jul 14, 2021
|
Thanks! |
This was referenced Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #42395.
This PR improves documentation for all
get_theme_*(),has_theme_*(),add_theme_*_override(),has_theme_*_override()andremove_theme_*_override()methods to make the descriptions more factual and closer in the language they use. Also some examples were outdated.Cherry-picking is not possible due to many renames and changes, so a dedicated 3.x PR should be created instead.