Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak Light3D property hints for greater flexibility #50506

Merged
merged 1 commit into from
Jun 13, 2022
Merged

Tweak Light3D property hints for greater flexibility #50506

merged 1 commit into from
Jun 13, 2022

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jul 16, 2021 •
edited
Loading

master version of #50507.

  • Specular can now be set above 1.0.
  • Blur can be set to 0 to disable shadow blurring entirely, which is useful on lights that have a non-zero size.
    • When shadow blurring is disabled, lights that have a non-zero size will not use PCSS-like soft shadows, speeding up shadow rendering considerably.
  • Some property hints now allow more precise values.

@Calinou Calinou requested review from a team as code owners July 16, 2021 01:51
@Calinou Calinou added this to the 4.0 milestone Jul 16, 2021
@Calinou Calinou mentioned this pull request Jul 16, 2021
Merged
@Calinou Calinou mentioned this pull request Oct 7, 2021
Closed
@Calinou Calinou force-pushed the light3d-increase-shadow-blur branch from 32bf724 to 063502e Compare February 4, 2022 00:26
@Calinou
Copy link
Member Author

Calinou commented Feb 4, 2022 •
edited
Loading

I rebased this pull request to follow #50507 more closely. Default shadow blur is no longer increased as it tended to make issues with shadow acne more obvious, on top of looking more noisy at low resolutions.

@Calinou Calinou changed the title Increase the default Light3D shadow blur by 50% Tweak Light3D property hints for greater flexibility Feb 4, 2022
@Calinou Calinou force-pushed the light3d-increase-shadow-blur branch from 063502e to bf992e4 Compare February 4, 2022 00:28
@Calinou Calinou force-pushed the light3d-increase-shadow-blur branch from bf992e4 to a5c5d51 Compare June 10, 2022 15:02
@akien-mga
Copy link
Member

Needs a rebase.

@Calinou
Tweak Light3D property hints for greater flexibility
0225c6d 
- Specular can now be set above 1.0.
- Blur can be set to 0 to disable shadow blurring entirely, which is useful
  on lights that have a non-zero size.
  - When shadow blurring is disabled, lights that have a non-zero size will
    not use PCSS-like soft shadows, speeding up shadow rendering
    considerably.
- Some property hints now allow more precise values.
@Calinou Calinou force-pushed the light3d-increase-shadow-blur branch from a5c5d51 to 0225c6d Compare June 13, 2022 12:32
@akien-mga akien-mga merged commit 6246240 into godotengine:master Jun 13, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:rendering topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Calinou @akien-mga @clayjohn