-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get_buffered_amount() to WebRTCDataChannel (Godot 3.x) #50659
Add get_buffered_amount() to WebRTCDataChannel (Godot 3.x) #50659
Conversation
d2340f5
to
58ec58d
Compare
If we want to backport this cleanly to And add a new That way the old version of the plugin would still work with the new version of the engine. |
Oh, cool! I didn't realize there was a mechanism in place for this. :-) I'll update this PR and the gdnative one to use that approach. |
58ec58d
to
5b2dcc5
Compare
PR is now updated to preserve backcompat! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
Thanks! |
Thanks for the review and speedy merge! :-) I've made a PR to godot-headers that should allow the official GDNative plugin to build: |
Yeah, I was actually too hasty :(. And the |
I just created these two PRs to fix those |
Update GDNative API version for changes from #50659
Update GDNative API version for changes from #50659 (Godot 3.x)
Godot 3.x version of PR #50658