Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use allowEmpty parameter in Split #51009

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

raulsntos
Copy link
Member

The allowEmpty parameter wasn't being used in the C# Split method.

@raulsntos raulsntos requested a review from a team as a code owner July 29, 2021 11:00
@Calinou Calinou added bug cherrypick:3.3 cherrypick:3.x Considered for cherry-picking into a future 3.x release topic:dotnet labels Jul 29, 2021
@Calinou Calinou added this to the 4.0 milestone Jul 29, 2021
@akien-mga akien-mga merged commit bdcc874 into godotengine:master Jul 29, 2021
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the fix-csharp-split branch July 29, 2021 21:04
@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Aug 3, 2021
@akien-mga
Copy link
Member

Cherry-picked for 3.3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants